[ https://issues.apache.org/jira/browse/YARN-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088655#comment-14088655 ]
Junping Du commented on YARN-2288: ---------------------------------- Thanks for review, [~zjshen]! Please see my reply below: bq. but TS_STORE_VERSION_KEY is going to be a common constant across different impls. In addition, TS_STORE_VERSION_KEY -> TIMELINE_STORE_VERSION_KEY? Actually, I had a long discussion with Jason on YARN-2045 and both of us think we should keep API (include public constant) as simple as possible. This key will not be used outside of class or sub-classes, so there is no hard requirement to put it over its parent class (an interface actually), the only value to put this to parent class is one line code reuse but this is not necessary for some other sub-classes (i.e MemoryTimelineStore) and bring extra complexity to interface which is simple now. So I prefer it to stay at sub class until HBase implementation is there and we have strong feeling to share it across different impls. Thoughts? I will fix the name issue here. bq. T -> t? Nice catch. Will fix it soon. bq. Unnecessary change for "- @SuppressWarnings("resource")"? That just fix a Javac warning. Fix it in a separated patch sounds overkill, so include a fix here. > Data persistent in timelinestore should be versioned > ---------------------------------------------------- > > Key: YARN-2288 > URL: https://issues.apache.org/jira/browse/YARN-2288 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: 2.4.1 > Reporter: Junping Du > Assignee: Junping Du > Attachments: YARN-2288-v2.patch, YARN-2288-v3.patch, YARN-2288.patch > > > We have LevelDB-backed TimelineStore, it should have schema version for > changes in schema in future. -- This message was sent by Atlassian JIRA (v6.2#6252)