Wangda Tan commented on YARN-2249:

Hi [~jianhe],
Thanks for update, several minor comments:

+  private final Object object = new Object();
Please change this to a more meaningful name.

+    }, yarnConf.getInt(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
+      YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS));
I found this is used several times, it's better to make it as a member of AYS


> RM may receive container release request on AM resync before container is 
> actually recovered
> --------------------------------------------------------------------------------------------
>                 Key: YARN-2249
>                 URL: https://issues.apache.org/jira/browse/YARN-2249
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-2249.1.patch, YARN-2249.1.patch, YARN-2249.2.patch, 
> YARN-2249.2.patch, YARN-2249.3.patch
> AM resync on RM restart will send outstanding container release requests back 
> to the new RM. In the meantime, NMs report the container statuses back to RM 
> to recover the containers. If RM receives the container release request  
> before the container is actually recovered in scheduler, the container won't 
> be released and the release request will be lost.

This message was sent by Atlassian JIRA

Reply via email to