Steve Loughran commented on YARN-2392:

...there's no tests here as there is nothing to test except for visual review 
of the message.

A lot of existing tests do look for the "Failed the application" string at the 
end of the message, with that string hard coded into the test methods. Those 
should really be reworked to use a constant string, as otherwise they are very 
brittle. This patch leaves the relevant text alone to avoid breaking anything.

> add more diags about app retry limits on AM failures
> ----------------------------------------------------
>                 Key: YARN-2392
>                 URL: https://issues.apache.org/jira/browse/YARN-2392
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>         Attachments: YARN-2392-001.patch
> # when an app fails the failure count is shown, but not what the global + 
> local limits are. If the two are different, they should both be printed. 
> # the YARN-2242 strings don't have enough whitespace between text and the URL

This message was sent by Atlassian JIRA

Reply via email to