[ 
https://issues.apache.org/jira/browse/YARN-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091539#comment-14091539
 ] 

Hadoop QA commented on YARN-2302:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12660727/YARN-2302.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/4566//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4566//console

This message is automatically generated.

> Refactor TimelineWebServices
> ----------------------------
>
>                 Key: YARN-2302
>                 URL: https://issues.apache.org/jira/browse/YARN-2302
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-2302.1.patch, YARN-2302.2.patch
>
>
> Now TimelineWebServices contains non-trivial logic to process the HTTP 
> requests, manipulate the data, check the access, and interact with the 
> timeline store.
> I propose the move the data-oriented logic to a middle layer (so called 
> TimelineDataManager), and TimelineWebServices only processes the requests, 
> and call TimelineDataManager to complete the remaining tasks.
> By doing this, we make the generic history module reuse TimelineDataManager 
> internally (YARN-2033), invoking the putting/getting methods directly. 
> Otherwise, we have to send the HTTP requests to TimelineWebServices to query 
> the generic history data, which is not an efficient way.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to