[ 
https://issues.apache.org/jira/browse/YARN-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092511#comment-14092511
 ] 

Varun Saxena commented on YARN-2138:
------------------------------------

[~jianhe], yes you are correct. When I apply the patch on a LINUX machine, it 
doesnt delete the file. Even the new patch which I generate doesn't delete the 
file. This may have to do with the fact that my patch is being generated on 
WINDOWS machine.  

Can you run the patch with below command ? This will delete the empty file.
patch -p0 -E < YARN-2138.003.patch 

I will upload a new patch too with latest code taken from trunk.

> Cleanup notifyDone* methods in RMStateStore
> -------------------------------------------
>
>                 Key: YARN-2138
>                 URL: https://issues.apache.org/jira/browse/YARN-2138
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Varun Saxena
>         Attachments: YARN-2138.002.patch, YARN-2138.003.patch, 
> YARN-2138.004.patch, YARN-2138.patch
>
>
> The storedException passed into notifyDoneStoringApplication is always null. 
> Similarly for other notifyDone* methods. We can clean up these methods as 
> this control flow path is not used anymore.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to