[
https://issues.apache.org/jira/browse/YARN-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093597#comment-14093597
]
Sandy Ryza commented on YARN-2399:
----------------------------------
Also, can we move all the methods that implement methods in Schedulable
together?
{code}
+ // TODO (KK): Rename these
{code}
Rename these?
{code}
- new
ConcurrentHashMap<ApplicationId,SchedulerApplication<FSSchedulerApp>>();
+ new
ConcurrentHashMap<ApplicationId,SchedulerApplication<FSAppAttempt>>();
{code}
Mind adding a space here after ApplicationId because you're fixing this line
anyway?
{code}
+ private FSAppAttempt mockAppSched(long startTime) {
+ FSAppAttempt schedApp = mock(FSAppAttempt.class);
+ when(schedApp.getStartTime()).thenReturn(startTime);
+ return schedApp;
}
{code}
Call this mockAppAttempt?
Otherwise, LGTM
> FairScheduler: Merge AppSchedulable and FSSchedulerApp into FSAppAttempt
> ------------------------------------------------------------------------
>
> Key: YARN-2399
> URL: https://issues.apache.org/jira/browse/YARN-2399
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.5.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-2399-1.patch, yarn-2399-2.patch
>
>
> FairScheduler has two data structures for an application, making the code
> hard to track. We should merge these for better maintainability in the
> long-term.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
