Ashwin Shankar commented on YARN-2393:

Thanks [~ywskycn]. More comments :
1. Currently maxAMResource is bounded by instantaneous fair share. The 
implication is that, a queue may suddenly get 100%  instantaneous fair share, 
which could all be consumed by AM containers. Should we bound maxAMResource by 
steady fair share instead, which doesn't fluctuate ?

public boolean canRunAppAM(Resource amResource) {
    float maxAMShare =
    if (Math.abs(maxAMShare - -1.0f) < 0.0001) {
      return true;
    Resource maxAMResource = Resources.multiply(getFairShare(), maxAMShare);
    Resource ifRunAMResource = Resources.add(amResourceUsage, amResource);
    return !policy
        .checkIfAMResourceUsageOverLimit(ifRunAMResource, maxAMResource);

2. Do you plan to do the "displaying of steady fair share on UI" in a different 
jira ?

> Fair Scheduler : Implement static fair share
> --------------------------------------------
>                 Key: YARN-2393
>                 URL: https://issues.apache.org/jira/browse/YARN-2393
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>            Reporter: Ashwin Shankar
>            Assignee: Wei Yan
>         Attachments: YARN-2393-1.patch, YARN-2393-2.patch, YARN-2393-3.patch
> Static fair share is a fair share allocation considering all(active/inactive) 
> queues.It would be shown on the UI for better predictability of finish time 
> of applications.
> We would compute static fair share only when needed, like on queue creation, 
> node added/removed. Please see YARN-2026 for discussions on this. 

This message was sent by Atlassian JIRA

Reply via email to