Anubhav Dhoot commented on YARN-1372:

Addressed feedback  such as adding tests and removing unnecessary changes.

> getApplicationsToCleanup
Using the containerExitCode to figure it the container is cleaned up because of 
application exit to decide how long to remember the container. Not sure if 
there is an easier way to link the two right now as the application cleanup 
lifecycle also converts into a Container Kill just like any other container 
Kill. Lemme know if you think there is a better way

> In RMAppAttemptImpl, why add a new previousJustFinishedContainers?
This it to allow a separate set of justFinishedContainers that can be used for 
returning to AM and at the same time acknowledging the previous returned set to 

>DECOMMISSIONED/LOST state possible to receive the new event? 
Not sure i follow. Can you please elaborate?

> Ensure all completed containers are reported to the AMs across RM restart
> -------------------------------------------------------------------------
>                 Key: YARN-1372
>                 URL: https://issues.apache.org/jira/browse/YARN-1372
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-1372.001.patch, YARN-1372.prelim.patch, 
> YARN-1372.prelim2.patch
> Currently the NM informs the RM about completed containers and then removes 
> those containers from the RM notification list. The RM passes on that 
> completed container information to the AM and the AM pulls this data. If the 
> RM dies before the AM pulls this data then the AM may not be able to get this 
> information again. To fix this, NM should maintain a separate list of such 
> completed container notifications sent to the RM. After the AM has pulled the 
> containers from the RM then the RM will inform the NM about it and the NM can 
> remove the completed container from the new list. Upon re-register with the 
> RM (after RM restart) the NM should send the entire list of completed 
> containers to the RM along with any other containers that completed while the 
> RM was dead. This ensures that the RM can inform the AM's about all completed 
> containers. Some container completions may be reported more than once since 
> the AM may have pulled the container but the RM may die before notifying the 
> NM about the pull.

This message was sent by Atlassian JIRA

Reply via email to