[ 
https://issues.apache.org/jira/browse/YARN-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101045#comment-14101045
 ] 

zhihai xu commented on YARN-2315:
---------------------------------

Karthik, thanks for the review. I will implement a test case. Also 
setCurrentCapacity should be 
getResourceUsage().getMemory()/getFairShare().getMemory()(current capacity is 
percentage resource used in your share). I will make this change also.

> Should use setCurrentCapacity instead of setCapacity to configure used 
> resource capacity for FairScheduler.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2315
>                 URL: https://issues.apache.org/jira/browse/YARN-2315
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2315.patch
>
>
> Should use setCurrentCapacity instead of setCapacity to configure used 
> resource capacity for FairScheduler.
> In function getQueueInfo of FSQueue.java, we call setCapacity twice with 
> different parameters so the first call is overrode by the second call. 
>     queueInfo.setCapacity((float) getFairShare().getMemory() /
>         scheduler.getClusterResource().getMemory());
>     queueInfo.setCapacity((float) getResourceUsage().getMemory() /
>         scheduler.getClusterResource().getMemory());
> We should change the second setCapacity call to setCurrentCapacity to 
> configure the current used capacity.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to