Varun Saxena commented on YARN-2432:

1. No new tests are needed. Just flipped over the sequence of statements.
2. Release Audit warnings are unrelated to the code changed. Its showing 
problems in some HDFS file.
3. Core test failure is unrelated to code change as well.

Will cancel and submit patch again

> RMStateStore should process the pending events before close
> -----------------------------------------------------------
>                 Key: YARN-2432
>                 URL: https://issues.apache.org/jira/browse/YARN-2432
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-2432.patch
> Refer to discussion on YARN-2136 
> (https://issues.apache.org/jira/browse/YARN-2136?focusedCommentId=14097266&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14097266).
> As pointed out by [~jianhe], we should process the dispatcher event queue 
> before closing the state store by flipping over the following statements in 
> code.
> {code:title=RMStateStore.java|borderStyle=solid}
>  protected void serviceStop() throws Exception {
>     closeInternal();
>     dispatcher.stop();
>   }
> {code}
> Currently, if the state store is being stopped on events such as switching to 
> standby, it will first close the state store(in case of ZKRMStateStore, close 
> connection with ZK) and then process the pending events. Instead, we should 
> first process the pending events and then call close.

This message was sent by Atlassian JIRA

Reply via email to