Tsuyoshi OZAWA commented on YARN-2454:

[~yxls123123], please generate your patch at root directory of the source code.

Additional minor nits: how about moving the tests to 
org.apache.hadoop.yarn.server.resource.TestResorces instead of adding a new 

> The function compareTo of variable UNBOUNDED in 
> org.apache.hadoop.yarn.util.resource.Resources is definited wrong.
> ------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-2454
>                 URL: https://issues.apache.org/jira/browse/YARN-2454
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0, 2.5.0, 2.4.1
>            Reporter: Xu Yang
>         Attachments: YARN-2454-patch.diff, YARN-2454.patch
> The variable UNBOUNDED implement the abstract class Resources, and override 
> the function compareTo. But there is something wrong in this function. We 
> should not compare resources with zero as the same as the variable NONE. We 
> should change 0 to Integer.MAX_VALUE.

This message was sent by Atlassian JIRA

Reply via email to