Jian He commented on YARN-1506:

We need to check the current state also ? if running send this event, else not
     // Update scheduler node's capacity for reconnect node.
          new NodeResourceUpdateSchedulerEvent(rmNode, 
              ResourceOption.newInstance(rmNode.totalCapability, -1)));
bq. AdminService plays almost like stateless client 
AdminService is server side implementation, right?
- we need to wait for some time after “alloc1Response = am1.schedule();”, as 
the allocations happens asynchronously. 
    alloc1Response = am1.schedule();
    Assert.assertEquals("Shouldn't have enough resource to allocate containers",
        0, alloc1Response.getAllocatedContainers().size());
- Do we have tests for testing increase resource scenario?
bq. How about addressing this in a separated JIRA?
The testResourceOverCommit seems almost duplicated. maybe lets start from here, 
as I think duplicating them now will become review/maintenance overhead later. 
TestWorkPreservingRMRestart has the structure for parameterizing scheduler 
- how about just merging updateResourceOnSchedulerNode into updateNodeResource, 
as they semantically look the same.

> Replace set resource change on RMNode/SchedulerNode directly with event 
> notification.
> -------------------------------------------------------------------------------------
>                 Key: YARN-1506
>                 URL: https://issues.apache.org/jira/browse/YARN-1506
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, scheduler
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-1506-v1.patch, YARN-1506-v10.patch, 
> YARN-1506-v11.patch, YARN-1506-v12.patch, YARN-1506-v13.patch, 
> YARN-1506-v14.patch, YARN-1506-v2.patch, YARN-1506-v3.patch, 
> YARN-1506-v4.patch, YARN-1506-v5.patch, YARN-1506-v6.patch, 
> YARN-1506-v7.patch, YARN-1506-v8.patch, YARN-1506-v9.patch
> According to Vinod's comments on YARN-312 
> (https://issues.apache.org/jira/browse/YARN-312?focusedCommentId=13846087&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13846087),
>  we should replace RMNode.setResourceOption() with some resource change event.

This message was sent by Atlassian JIRA

Reply via email to