[ 
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei Yan updated YARN-2395:
--------------------------

    Attachment: YARN-2395-5.patch

Update a patch to address Karthik's comments.
bq.Can we augment the test (or add a new one) to verify we are not breaking 
backward compatibility with the preemptionTimeout defaults?
I have already added testcase both in TestAllocationFileLoaderService and 
TestFairScheduler.
TestAllocationFileLoaderService.testBackwardsCompatibleAllocationFileParsing().
{code}
    // Set fair share preemption timeout to 5 minutes
    out.println("<fairSharePreemptionTimeout>300</fairSharePreemptionTimeout>");
    out.println("</allocations>");
{code}
TestFairScheduler.testBackwardsCompatiblePreemptionConfiguration().
{code}
    
out.print("<defaultMinSharePreemptionTimeout>15</defaultMinSharePreemptionTimeout>");
    
out.print("<defaultFairSharePreemptionTimeout>25</defaultFairSharePreemptionTimeout>");
    out.print("<fairSharePreemptionTimeout>30</fairSharePreemptionTimeout>");
    out.println("</allocations>");
{code}

> FairScheduler: Preemption timeout should be configurable per queue
> ------------------------------------------------------------------
>
>                 Key: YARN-2395
>                 URL: https://issues.apache.org/jira/browse/YARN-2395
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: fairscheduler
>            Reporter: Ashwin Shankar
>            Assignee: Wei Yan
>         Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, 
> YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch
>
>
> Currently in fair scheduler, the preemption logic considers fair share 
> starvation only at leaf queue level. This jira is created to implement it at 
> the parent queue as well.
> It involves :
> 1. Making "check for fair share starvation" and "amount of resource to 
> preempt"  recursive such that they traverse the queue hierarchy from root to 
> leaf.
> 2. Currently fairSharePreemptionTimeout is a global config. We could make it 
> configurable on a per queue basis,so that we can specify different timeouts 
> for parent queues.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to