[
https://issues.apache.org/jira/browse/YARN-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Payne updated YARN-2056:
-----------------------------
Attachment: YARN-2056.201408310117.txt
{quote}
1) I prefer to make per-queue disable preemption option follow the same config
options in existing capacity-scheduler (same queue-path-prefix, etc.).
{quote}
Do you mean that the prefix should be {{yarn.scheduler.capacity}} instead of
{{yarn.resourcemanager.monitor.capacity.preemption}}? I have done this in this
patch.
{quote}
2) {{mockNested}} {{when(q.getQueuePath())}} should consider hierarchy of
queue as well
{quote}
I have added this
{quote}
3) It's better to add tests for hierarchy of queues when preemption is disabled
{quote}
I have not done this yet, but I wanted to get the rest of this patch up for you.
{quote}
4) In {{testPerQueueDisablePreemption}}, I think number of preemptions after
enable queue-b's preemption is not very clear to me:
{code}
+ // With no PREEMPTION_DISABLED set for queueB, get resources from both
+ // queueB and queueC (times() assertion is cumulative).
+ verify(mDisp, times(5)).handle(argThat(new IsPreemptionRequestFor(appB)));
+ verify(mDisp, times(16)).handle(argThat(new IsPreemptionRequestFor(appC)));
{code}
In the 2nd preemption, more resource reclaimed from appC than appB, I think it
should get resource from app more, could you please take a look at what
happened? I just afraid because we changed ideal resource calculation in 1st
preemption, is it possible to affect 2nd preemption
{quote}
The problem with the mock of {{EventHandler<ContainerPreemptEvent>
}} (which is the {{mDisp}} variable) is that it counts the total number of
events sent to the queue ({{queuec}}, for example), so for the second assertion
that was acting upon {{queueC}}, I had to account for the total number of
events, not just those for the second call to {{policy.editSchedule()}}. So,
what I did for this patch is reset the test between the first and second calls
to {{policy.editSchedule()}}
> Disable preemption at Queue level
> ---------------------------------
>
> Key: YARN-2056
> URL: https://issues.apache.org/jira/browse/YARN-2056
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.4.0
> Reporter: Mayank Bansal
> Assignee: Eric Payne
> Attachments: YARN-2056.201408202039.txt, YARN-2056.201408260128.txt,
> YARN-2056.201408310117.txt
>
>
> We need to be able to disable preemption at individual queue level
--
This message was sent by Atlassian JIRA
(v6.2#6252)
