[
https://issues.apache.org/jira/browse/YARN-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119278#comment-14119278
]
Ashwin Shankar commented on YARN-2394:
--------------------------------------
[~ywskycn], patch looks almost good. Couple of comments :
1.
{code:title=FSLeafQueue.java}
Resource desiredShare = Resources.min(scheduler.getResourceCalculator(),
scheduler.getClusterResource(), share, getDemand());
return Resources.lessThan(scheduler.getResourceCalculator(),
scheduler.getClusterResource(), getResourceUsage(), desiredShare);
{code}
getResourceCalculator() is a static method, can you please access it through
the class and not the object.
2. Nit
{code:title=AllocationConfiguration.java}
// The fair share preemption threshold for each queue. It a queue waits
{code}
"It" should be "If"
> FairScheduler: Configure fairSharePreemptionThreshold per queue
> ---------------------------------------------------------------
>
> Key: YARN-2394
> URL: https://issues.apache.org/jira/browse/YARN-2394
> Project: Hadoop YARN
> Issue Type: New Feature
> Components: fairscheduler
> Reporter: Ashwin Shankar
> Assignee: Wei Yan
> Attachments: YARN-2394-1.patch, YARN-2394-2.patch, YARN-2394-3.patch,
> YARN-2394-4.patch, YARN-2394-5.patch
>
>
> Preemption based on fair share starvation happens when usage of a queue is
> less than 50% of its fair share. This 50% is hardcoded. We'd like to make
> this configurable on a per queue basis, so that we can choose the threshold
> at which we want to preempt. Calling this config
> "fairSharePreemptionThreshold".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
