[
https://issues.apache.org/jira/browse/YARN-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121737#comment-14121737
]
Vinod Kumar Vavilapalli commented on YARN-1708:
-----------------------------------------------
Tx for the updated patch, [~subru]! This looks so much better!
A few minor comments
- All the newInstance methods and setters in the response objects should be
marked as private, for e.g in ReservationSubmissionResponse. Similarly in other
objects too. We don't expect users to call them because responses are generated
only by the platform.
- ReservationId: It's likely that IDEs generate a better hashCode instead of
us doing the long-to-int conversions?
- ReservationRequests.{set|get}Type -> {set|get}Interpretor? Similarly
ReservationRequestsProto.type.
- Rename ReservationRequest.leaseDuration to be simply duration inline with
ReservationRequestProto.duration
> Add a public API to reserve resources (part of YARN-1051)
> ---------------------------------------------------------
>
> Key: YARN-1708
> URL: https://issues.apache.org/jira/browse/YARN-1708
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Carlo Curino
> Assignee: Subramaniam Krishnan
> Attachments: YARN-1708.patch, YARN-1708.patch
>
>
> This JIRA tracks the definition of a new public API for YARN, which allows
> users to reserve resources (think of time-bounded queues). This is part of
> the admission control enhancement proposed in YARN-1051.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
