[
https://issues.apache.org/jira/browse/YARN-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated YARN-2519:
--------------------------------
Target Version/s: 2.6.0
Assignee: Xiaoyu Yao
Hadoop Flags: Reviewed
+1 for the patch. I verified the test on Mac and Windows. I'll commit this
soon.
> Credential Provider related unit tests failed on Windows
> --------------------------------------------------------
>
> Key: YARN-2519
> URL: https://issues.apache.org/jira/browse/YARN-2519
> Project: Hadoop YARN
> Issue Type: Test
> Components: webapp
> Affects Versions: 2.4.1
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: YARN-2519.0.patch
>
>
> Reported by: Xiaomara and investigated by Chris Nauroth.
> The credential provider related unit tests failed on Windows. The tests try
> to set up a URI by taking the build test directory and concatenating it with
> other strings containing the rest of the URI format, i.e.:
> {code}
> public void testFactory() throws Exception {
> Configuration conf = new Configuration();
> conf.set(CredentialProviderFactory.CREDENTIAL_PROVIDER_PATH,
> UserProvider.SCHEME_NAME + ":///," +
> JavaKeyStoreProvider.SCHEME_NAME + "://file" + tmpDir +
> "/test.jks");
> {code}
> This logic is incorrect on Windows, because the file path separator will be
> '\', which violates URI syntax. Forward slash is not permitted.
> The proper fix is to always do path/URI construction through the
> org.apache.hadoop.fs.Path class, specifically using the constructors that
> take explicit parent and child arguments.
> The affected unit tests are:
> {code}
> * TestWebAppUtils
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
