[ https://issues.apache.org/jira/browse/YARN-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Subramaniam Krishnan updated YARN-1712: --------------------------------------- Attachment: YARN-1712.3.patch Thanks [~jianhe] for your detailed feedback. I am attaching a patch with the following updates: * Made move apps logic synchronous and move is to defReservationQueue (renamed) * Removed the synchronized on scheduler as individual calls are already synchronized * Fixed comment formatting and variable names * Created a common method to calculate lhsRes and rhsRes * Optimized the loop as suggested Some clarifications: * Exceptions are suppressed deliberately as PlanFollower is a background timer thread and we don't want it to exit * _plan.getReservationsAtTime(now)_ is used by others like Replanners. We need the reservations and not just the names even in PlanFollower so leaving it as is * Tried moving the default queue creating to when PlanQueue is initialized in CapacityScheduler but it was getting overly complex mainly due to the relaxed constraint of child capacities <=100% for PlanQueues. This is just an additional hashmap lookup with the code being much cleaner so not moving it for now. If it is still a concern, I can add a flag to Plan and check that instead of CapacityScheduler#getQueue > Admission Control: plan follower > -------------------------------- > > Key: YARN-1712 > URL: https://issues.apache.org/jira/browse/YARN-1712 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler, resourcemanager > Reporter: Carlo Curino > Assignee: Carlo Curino > Labels: reservations, scheduler > Attachments: YARN-1712.1.patch, YARN-1712.2.patch, YARN-1712.3.patch, > YARN-1712.patch > > > This JIRA tracks a thread that continuously propagates the current state of > an inventory subsystem to the scheduler. As the inventory subsystem store the > "plan" of how the resources should be subdivided, the work we propose in this > JIRA realizes such plan by dynamically instructing the CapacityScheduler to > add/remove/resize queues to follow the plan. -- This message was sent by Atlassian JIRA (v6.3.4#6332)