[ 
https://issues.apache.org/jira/browse/YARN-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129610#comment-14129610
 ] 

Jian He commented on YARN-2496:
-------------------------------

briefly looked at the patch:
- CSQueueUtils.java format change only, we can revert
- why checking {{labelManager != null}} every where  ? we only need to check 
where it’s needed.
- We may not need to change the method signature to add one more parameter, 
just pass the queues map into NodeLabelManager#reinitializeQueueLabels, to 
avoid a number of test changes.
{code}
parseQueue(this, conf, null, CapacitySchedulerConfiguration.ROOT, 
            queues, queues, noop, queueToLabels);
{code}
- label initialization code is duplicated between ParentQueue and LeafQueue, 
how about creating an AbstractCSQueue and put common initilazation methods 
there ?

> [YARN-796] Changes for capacity scheduler to support allocate resource 
> respect labels
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2496
>                 URL: https://issues.apache.org/jira/browse/YARN-2496
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2496.patch
>
>
> This JIRA Includes:
> - Add/parse labels option to {{capacity-scheduler.xml}} similar to other 
> options of queue like capacity/maximum-capacity, etc.
> - Include a "default-label-expression" option in queue config, if an app 
> doesn't specify label-expression, "default-label-expression" of queue will be 
> used.
> - Check if labels can be accessed by the queue when submit an app with 
> labels-expression to queue or update ResourceRequest with label-expression
> - Check labels on NM when trying to allocate ResourceRequest on the NM with 
> label-expression
> - Respect  labels when calculate headroom/user-limit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to