Zhijie Shen commented on YARN-2527:

bq. But I believe, the NullPointer issue in ApplicationACLsManager should be 
fixed regardless of that.

My concern is that each submitted app should have a map of acls in the acls 
manager, even if it is empty. If we make this change, we may hide some 
potential bugs.

I looked into RMAppManager.createAndPopulateNewRMApp: app is put into RMContext 
first and then its acls is put into ApplicationACLsManager.

In AppBlock, app is obtained from RMContext, and then its acls is going to be 
checked. If this happens after app is put into RMContext, but its acls isn't 
put into ApplicationACLsManager yet, user should hit the NPE case.

Would you please see whether it is the race condition that you ran into before?

> NPE in ApplicationACLsManager
> -----------------------------
>                 Key: YARN-2527
>                 URL: https://issues.apache.org/jira/browse/YARN-2527
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.5.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: YARN-2527.patch, YARN-2527.patch
> NPE in _ApplicationACLsManager_ can result in 500 Internal Server Error.
> The relevant stacktrace snippet from the ResourceManager logs is as below
> {code}
> Caused by: java.lang.NullPointerException
>         at 
> org.apache.hadoop.yarn.server.security.ApplicationACLsManager.checkAccess(ApplicationACLsManager.java:104)
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.webapp.AppBlock.render(AppBlock.java:101)
>         at 
> org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:66)
>         at 
> org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:76)
>         at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> {code}
> This issue was reported by [~miguenther].

This message was sent by Atlassian JIRA

Reply via email to