Carlo Curino commented on YARN-1710:

[~chris.douglas], thanks for the always insightful feedback. 

I attach a patch addressing all your comments with two minor exceptions:
 * I am not memoizing findEarliestTime, as it would only save one invocation 
(the others are on diff sets, or updated version of the same set). Similarly 
TreeSet would only help partially, as we need to search for both 
min(startTime) and max(endTime), hence no single ordering can help both.
 * for the iterator on stages, I find the for loop less readable than a while 
(as the initialization and increment will be large/not very readable) 

The rest is done as you suggest. Let me know if it looks good or if there is 
anything else to be addressed.

> Admission Control: agents to allocate reservation
> -------------------------------------------------
>                 Key: YARN-1710
>                 URL: https://issues.apache.org/jira/browse/YARN-1710
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-1710.1.patch, YARN-1710.patch
> This JIRA tracks the algorithms used to allocate a user ReservationRequest 
> coming in from the new reservation API (YARN-1708), in the inventory 
> subsystem (YARN-1709) maintaining the current plan for the cluster. The focus 
> of this "agents" is to quickly find a solution for the set of contraints 
> provided by the user, and the physical constraints of the plan.

This message was sent by Atlassian JIRA

Reply via email to