[ 
https://issues.apache.org/jira/browse/YARN-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133368#comment-14133368
 ] 

Jian He commented on YARN-1712:
-------------------------------

thanks for updating ! Patch looks good, just few nits:
- Seems the previous method moveApplication call already prints this log msg, 
then we may just remove this.
{code}
        LOG.info("Moving application: {} from queue: {}  to queue: {}", app,
            expiredReservation, defReservationQueue);
{code}
- I meant we may have a common method for this whole thing to 
getUnallocatedReservedResources.
{code}
      CSQueue lhsQueue = scheduler.getQueue(lhs.getReservationId().toString());
      if (lhsQueue != null) {
        lhsRes = getUnallocatedCapacity(clusterResource, lhs, lhsQueue);
      } else {
        lhsRes = lhs.getResourcesAtTime(now);
      }
{code}
- In a couple of places, the indentation of the {{LOG.debug}} is incorrect 
- We can consolidate the following two log statements into one, as they are 
executed in the same place.
{code}
    LOG.debug("Plan total capacity is: {} and reserved capacity is: {}",
        planAbsCap, totalAssignedCapacity);
    LOG.debug("PlanFollowerEditPolicyTask: total Plan Capacity: {} "
          + "currReservation: {} default-queue capacity: {}", planResources,
          numRes, defQCap);
   }
{code}
- Briefly looked at the test cases. The two tests seem almost the same. I 
suggest we parameterize the two tests into one, which will be easier for people 
to review and maintenance. Regarding the differences with regard to kill and 
move. I would expect the tests to actually submit some apps to some reservation 
queue, and check the apps are actually moved to the default queue or simply 
killed, after the reservation expired.

> Admission Control: plan follower
> --------------------------------
>
>                 Key: YARN-1712
>                 URL: https://issues.apache.org/jira/browse/YARN-1712
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>              Labels: reservations, scheduler
>         Attachments: YARN-1712.1.patch, YARN-1712.2.patch, YARN-1712.3.patch, 
> YARN-1712.4.patch, YARN-1712.patch
>
>
> This JIRA tracks a thread that continuously propagates the current state of 
> an inventory subsystem to the scheduler. As the inventory subsystem store the 
> "plan" of how the resources should be subdivided, the work we propose in this 
> JIRA realizes such plan by dynamically instructing the CapacityScheduler to 
> add/remove/resize queues to follow the plan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to