Zhijie Shen commented on YARN-1250:

bq.  If we do think the call can be reasonably neglected, we should at least 
document the reason so others will pay attention to it when reusing this method 
in future.

RM will always invoke these methods in SystemMetricsPublisher. If we make a log 
when the service is disabled, SystemMetricsPublisher will create a bunch of 
logs when RM runs with the service disabled. Anyway, I added javadoc to 
describe the expected behavior here.

> Generic history service should support application-acls
> -------------------------------------------------------
>                 Key: YARN-1250
>                 URL: https://issues.apache.org/jira/browse/YARN-1250
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Zhijie Shen
>         Attachments: GenericHistoryACLs.pdf, YARN-1250.1.patch, 
> YARN-1250.2.patch, YARN-1250.3.patch, YARN-1250.4.patch, YARN-1250.5.patch, 
> YARN-1250.6.patch

This message was sent by Atlassian JIRA

Reply via email to