Karthik Kambatla commented on YARN-2080:

Looks mostly good. Nits: There are some unused imports and javadoc errors in 
the files. Also, a couple of class javadocs have empty lines at the end.
# It would be nice to not have default values for configs for ReservationSystem 
and PlanFollower. We could pick these defaults based on the scheduler. 
# I am not convinced using UTCClock is the best way, particularly when client 
time in not UTC. But, I guess we can go ahead with this for now and revisit it 
when we run into problems. 

> Admission Control: Integrate Reservation subsystem with ResourceManager
> -----------------------------------------------------------------------
>                 Key: YARN-2080
>                 URL: https://issues.apache.org/jira/browse/YARN-2080
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Subru Krishnan
>         Attachments: YARN-2080.patch, YARN-2080.patch, YARN-2080.patch, 
> YARN-2080.patch, YARN-2080.patch, YARN-2080.patch
> This JIRA tracks the integration of Reservation subsystem data structures 
> introduced in YARN-1709 with the YARN RM. This is essentially end2end wiring 
> of YARN-1051.

This message was sent by Atlassian JIRA

Reply via email to