Tsuyoshi OZAWA commented on YARN-2312:

Basically we can replace {{getId()}} with {{getContainerId()}} 
straightforwardly. [~jianhe], [~vinodkv], how can we deal with following 

1. {{WrappedJvmID}}. In TaskAttemptImpl, the id is created by using 
{{container.getId}}. If we change a constructor of {{WrapperedJvmID}}, we also 
need to change a constructor of {{ID}} class itself. One idea is to add {{id}} 
for upper 32 bits of container Id to {{ID}} class.
      taskAttempt.jvmID =
          new WrappedJvmID(taskAttempt.remoteTask.getTaskID().getJobID(),
            taskAttempt.remoteTask.isMapTask(), taskAttempt.container.getId()
2. {{Priority}}. Can we change the definition of Proto? It's used widely and 
one concern is backward compatibility.

> Marking ContainerId#getId as deprecated
> ---------------------------------------
>                 Key: YARN-2312
>                 URL: https://issues.apache.org/jira/browse/YARN-2312
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
> {{ContainerId#getId}} will only return partial value of containerId, only 
> sequence number of container id without epoch, after YARN-2229. We should 
> mark {{ContainerId#getId}} as deprecated and use 
> {{ContainerId#getContainerId}} instead.

This message was sent by Atlassian JIRA

Reply via email to