[ 
https://issues.apache.org/jira/browse/YARN-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142139#comment-14142139
 ] 

Vinod Kumar Vavilapalli commented on YARN-2168:
-----------------------------------------------

Few comments on the APIs
 - Let's mark all the APIs as evolving, or may be even unstable.
 - The setters for responses and objects that are supposed to be only created 
by the server should be marked Private - we don't expect users to use them. For 
e.g. UseSharedCacheResourceResponse.setPath()
 - Let's move SCMAdminProtocol  and all related records to 
org.apache.hadoop.yarn.server.api & 
org.apache.hadoop.yarn.server.api.protocolrecords packages.
 - We are using checksum, key, resource-key to all refer to the same entity. 
Shall we standardize on resource-key?

> SCM/Client/NM/Admin protocols
> -----------------------------
>
>                 Key: YARN-2168
>                 URL: https://issues.apache.org/jira/browse/YARN-2168
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>         Attachments: YARN-2168-trunk-v1.patch, YARN-2168-trunk-v2.patch
>
>
> This jira is meant to be used to review the main shared cache APIs. They are 
> as follows:
> * ClientSCMProtocol - The protocol between the yarn client and the cache 
> manager. This protocol controls how resources in the cache are claimed and 
> released.
> ** UseSharedCacheResourceRequest
> ** UseSharedCacheResourceResponse
> ** ReleaseSharedCacheResourceRequest
> ** ReleaseSharedCacheResourceResponse
> * SCMAdminProtocol - This is an administrative protocol for the cache 
> manager. It allows administrators to manually trigger cleaner runs.
> ** RunSharedCacheCleanerTaskRequest
> ** RunSharedCacheCleanerTaskResponse
> * NMCacheUploaderSCMProtocol - The protocol between the NodeManager and the 
> cache manager. This allows the NodeManager to coordinate with the cache 
> manager when uploading new resources to the shared cache.
> ** NotifySCMRequest
> ** NotifySCMResponse



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to