[ 
https://issues.apache.org/jira/browse/YARN-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142684#comment-14142684
 ] 

Karthik Kambatla commented on YARN-2453:
----------------------------------------

As of now, CapacityScheduler is the only scheduler that instantiates 
PreemptableResourceScheduler. How about, we set the scheduler explicitly in the 
setup method. The test should just reuse the configuration instead of creating 
another instance. 

> TestProportionalCapacityPreemptionPolicy is failed for FairScheduler
> --------------------------------------------------------------------
>
>                 Key: YARN-2453
>                 URL: https://issues.apache.org/jira/browse/YARN-2453
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2453.000.patch
>
>
> TestProportionalCapacityPreemptionPolicy is failed for FairScheduler.
> The following is error message:
> Running 
> org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy
> Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.94 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy
> testPolicyInitializeAfterSchedulerInitialized(org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy)
>   Time elapsed: 1.61 sec  <<< FAILURE!
> java.lang.AssertionError: Failed to find SchedulingMonitor service, please 
> check what happened
>       at org.junit.Assert.fail(Assert.java:88)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy.testPolicyInitializeAfterSchedulerInitialized(TestProportionalCapacityPreemptionPolicy.java:469)
> This test should only work for capacity scheduler because the following 
> source code in ResourceManager.java prove it will only work for capacity 
> scheduler.
> {code}
> if (scheduler instanceof PreemptableResourceScheduler
>           && conf.getBoolean(YarnConfiguration.RM_SCHEDULER_ENABLE_MONITORS,
>           YarnConfiguration.DEFAULT_RM_SCHEDULER_ENABLE_MONITORS)) {
> {code}
> Because CapacityScheduler is instance of PreemptableResourceScheduler and 
> FairScheduler is not  instance of PreemptableResourceScheduler.
> I will upload a patch to fix this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to