Craig Welch commented on YARN-2505:

-re rename all-nodes-to-lables to nodes-to-labels - done

-re node-filter, I don't think that it makes sense to switch it.  While 
code-wise I see where it is awkward to do a value filter, this follows the spec 
and it makes sense from a use case perspective - I expect that the desire is to 
find all of the nodes which have a particular label on them, that is the 
purpose of this filter and it makes sense to me that someone would want to do 
that and it seems to fit in with this api.  I think there are easier ways to 
see what labels are on a node, adding it as a filter to this kind of an api 
call makes little sense to me anyway as it is more-or-less a direct property of 
a node - if it's missing I think it belongs elsewhere else anyway.

Have shortened lines where found

> [YARN-796] Support get/add/remove/change labels in RM REST API
> --------------------------------------------------------------
>                 Key: YARN-2505
>                 URL: https://issues.apache.org/jira/browse/YARN-2505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Craig Welch
>         Attachments: YARN-2505.patch

This message was sent by Atlassian JIRA

Reply via email to