[ 
https://issues.apache.org/jira/browse/YARN-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144268#comment-14144268
 ] 

Zhijie Shen commented on YARN-2569:
-----------------------------------

LGTM in general. Some comments about the patch.

1. Per discussion offline, is it a bit aggressive to mark the new APIs 
\@Stable? In particular when the class is marked \@Evolving. BTW, should we 
make LogAggregationContext \@Public?

2. It's good to describe what kind of pattern the user should use? Wildcard 
patten? 
http://en.wikipedia.org/wiki/Wildcard_character#File_and_directory_patterns

3. Miss a full stop?
{code}
+ *     how often the logAggregationSerivce uploads container logs in seconds
{code}

4. The description is broken?
{code}
+   *          to set
{code}

5. It shouldn't be part of API?
{code}
+
+  @Private
+  public abstract LogAggregationContextProto getProto();
{code}

> Log Handling for LRS API Changes
> --------------------------------
>
>                 Key: YARN-2569
>                 URL: https://issues.apache.org/jira/browse/YARN-2569
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-2569.1.patch, YARN-2569.2.patch, YARN-2569.3.patch, 
> YARN-2569.4.1.patch, YARN-2569.4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to