[ 
https://issues.apache.org/jira/browse/YARN-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147167#comment-14147167
 ] 

Hadoop QA commented on YARN-2546:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12671087/apache-yarn-2546.1.patch
  against trunk revision 3cde37c.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5111//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5111//console

This message is automatically generated.

> REST API for application creation/submission is using strings for numeric & 
> boolean values
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-2546
>                 URL: https://issues.apache.org/jira/browse/YARN-2546
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 2.5.1
>            Reporter: Doug Haigh
>            Assignee: Varun Vasudev
>         Attachments: apache-yarn-2546.0.patch, apache-yarn-2546.1.patch
>
>
> When YARN responds with or accepts JSON, numbers & booleans are being 
> represented as strings which can cause parsing problems.
> Resource values look like 
> {
>   "application-id":"application_1404198295326_0001",
>   "maximum-resource-capability":
>    {
>       "memory":"8192",
>       "vCores":"32"
>    }
> }
> Instead of
> {
>   "application-id":"application_1404198295326_0001",
>   "maximum-resource-capability":
>    {
>       "memory":8192,
>       "vCores":32
>    }
> }
> When I POST to start a job, numeric values are represented as numbers:
>       "local-resources":
>       {
>         "entry":
>         [
>           {
>             "key":"AppMaster.jar",
>             "value":
>             {
>               
> "resource":"hdfs://hdfs-namenode:9000/user/testuser/DistributedShell/demo-app/AppMaster.jar",
>               "type":"FILE",
>               "visibility":"APPLICATION",
>               "size": "43004",
>               "timestamp": "1405452071209"
>             }
>           }
>         ]
>       },
> Instead of
>       "local-resources":
>       {
>         "entry":
>         [
>           {
>             "key":"AppMaster.jar",
>             "value":
>             {
>               
> "resource":"hdfs://hdfs-namenode:9000/user/testuser/DistributedShell/demo-app/AppMaster.jar",
>               "type":"FILE",
>               "visibility":"APPLICATION",
>               "size": 43004,
>               "timestamp": 1405452071209
>             }
>           }
>         ]
>       },
> Similarly, Boolean values are also represented as strings:
> "keep-containers-across-application-attempts":"false"
> Instead of 
> "keep-containers-across-application-attempts":false



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to