[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147476#comment-14147476
]
Hadoop QA commented on YARN-668:
--------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671145/YARN-668-v7.patch
against trunk revision 428a766.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5118//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5118//console
This message is automatically generated.
> TokenIdentifier serialization should consider Unknown fields
> ------------------------------------------------------------
>
> Key: YARN-668
> URL: https://issues.apache.org/jira/browse/YARN-668
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Junping Du
> Priority: Blocker
> Attachments: YARN-668-demo.patch, YARN-668-v2.patch,
> YARN-668-v3.patch, YARN-668-v4.patch, YARN-668-v5.patch, YARN-668-v6.patch,
> YARN-668-v7.patch, YARN-668.patch
>
>
> This would allow changing of the TokenIdentifier between versions. The
> current serialization is Writable. A simple way to achieve this would be to
> have a Proto object as the payload for TokenIdentifiers, instead of
> individual fields.
> TokenIdentifier continues to implement Writable to work with the RPC layer -
> but the payload itself is serialized using PB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
