Craig Welch commented on YARN-2494:

-re I suggest to change addLabels to addNodeLabels because we may support more 
different kind of labels in the future, change removeLabels to 
removeExistingLabels, and leave NodeLabelsManager.existingLabels unchanged.

I thought we'd setteled on just adding "Node" to the names which did not have 
it, so addNodeLables, removeNodeLabels, etc.  I don't think "Existing" and 
"Known" are particularly helpful, the concern was to distinguish these as 
"NodeLabel" operations, to leave room in the future for other kinds of nodes.

Also, with the refactor to a "store" type and dropping the configuration 
option, do we still have a way to specify something other than the hdfs store?

wrt leveldb - we ended up with hdfs for the ha case, I think anything we do 
should be distributed, not local - so zookeeper, hbase, etc.

> [YARN-796] Node label manager API and storage implementations
> -------------------------------------------------------------
>                 Key: YARN-2494
>                 URL: https://issues.apache.org/jira/browse/YARN-2494
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2494.patch, YARN-2494.patch, YARN-2494.patch, 
> YARN-2494.patch, YARN-2494.patch, YARN-2494.patch
> This JIRA includes APIs and storage implementations of node label manager,
> NodeLabelManager is an abstract class used to manage labels of nodes in the 
> cluster, it has APIs to query/modify
> - Nodes according to given label
> - Labels according to given hostname
> - Add/remove labels
> - Set labels of nodes in the cluster
> - Persist/recover changes of labels/labels-on-nodes to/from storage
> And it has two implementations to store modifications
> - Memory based storage: It will not persist changes, so all labels will be 
> lost when RM restart
> - FileSystem based storage: It will persist/recover to/from FileSystem (like 
> HDFS), and all labels and labels-on-nodes will be recovered upon RM restart

This message was sent by Atlassian JIRA

Reply via email to