[ 
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148074#comment-14148074
 ] 

Vinod Kumar Vavilapalli edited comment on YARN-668 at 9/25/14 9:19 PM:
-----------------------------------------------------------------------

Quick look at the patch
 - None of the records in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
 are supposed to be exposed to users. We can move it to a sub-folder server and 
explicit comment in the proto file saying they are not consumable.
 - What about other tokens? We have Client to AM token, RM delegation-tokens 
etc.


was (Author: vinodkv):
Quick look at the patch
 - None of the records in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
 are supposed to be exposed to users. We can move it to a sub-folder server and 
explicit comment in the proto file saying they are consumable.
 - What about other tokens? We have Client to AM token, RM delegation-tokens 
etc.

> TokenIdentifier serialization should consider Unknown fields
> ------------------------------------------------------------
>
>                 Key: YARN-668
>                 URL: https://issues.apache.org/jira/browse/YARN-668
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Junping Du
>            Priority: Blocker
>         Attachments: YARN-668-demo.patch, YARN-668-v2.patch, 
> YARN-668-v3.patch, YARN-668-v4.patch, YARN-668-v5.patch, YARN-668-v6.patch, 
> YARN-668-v7.patch, YARN-668-v8.patch, YARN-668.patch
>
>
> This would allow changing of the TokenIdentifier between versions. The 
> current serialization is Writable. A simple way to achieve this would be to 
> have a Proto object as the payload for TokenIdentifiers, instead of 
> individual fields.
> TokenIdentifier continues to implement Writable to work with the RPC layer - 
> but the payload itself is serialized using PB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to