[ 
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149952#comment-14149952
 ] 

Jian He commented on YARN-668:
------------------------------

Looks good overall, minor comments:
- In ContainerTokenIdentifier, check null as well ?similarly for all 
{{getUser}} ?
{code}
  public ContainerId getContainerID() {
    return new ContainerIdPBImpl(proto.getContainerId());
  }
{code}
- This change change can be reverted back 
{code}
 // LogAggregationContext is set as null
    Assert.assertNull(getLogAggregationContextFromContainerToken(rm1, nm1, 
null));
{code}

> TokenIdentifier serialization should consider Unknown fields
> ------------------------------------------------------------
>
>                 Key: YARN-668
>                 URL: https://issues.apache.org/jira/browse/YARN-668
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Junping Du
>            Priority: Blocker
>         Attachments: YARN-668-demo.patch, YARN-668-v2.patch, 
> YARN-668-v3.patch, YARN-668-v4.patch, YARN-668-v5.patch, YARN-668-v6.patch, 
> YARN-668-v7.patch, YARN-668-v8.patch, YARN-668-v9.patch, YARN-668.patch
>
>
> This would allow changing of the TokenIdentifier between versions. The 
> current serialization is Writable. A simple way to achieve this would be to 
> have a Proto object as the payload for TokenIdentifiers, instead of 
> individual fields.
> TokenIdentifier continues to implement Writable to work with the RPC layer - 
> but the payload itself is serialized using PB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to