Chris Trezzo updated YARN-2179:
    Attachment: YARN-2179-trunk-v10.patch

[~vinodkv] [~kasha]

Attached is v10.

Here is a new approach where I extend YarnClientImpl, stub out the service 
init/start/stop methods and mock the relevant methods to test. Does this seem 
like a cleaner approach to you guys?

I tried to do a straight mocking without extending the abstract class, but 
continually ran into the issue that AbstractService.stateModel is initialized 
in the constructor. This creates a problem when trying to stub 
AbstractService.getServiceState(), which is required for the AbstractService to 
work with a CompositeService.

Let me know if you don't like this approach or you know of an easier method and 
I can readjust the patch. Thanks!

> Initial cache manager structure and context
> -------------------------------------------
>                 Key: YARN-2179
>                 URL: https://issues.apache.org/jira/browse/YARN-2179
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>         Attachments: YARN-2179-trunk-v1.patch, YARN-2179-trunk-v10.patch, 
> YARN-2179-trunk-v2.patch, YARN-2179-trunk-v3.patch, YARN-2179-trunk-v4.patch, 
> YARN-2179-trunk-v5.patch, YARN-2179-trunk-v6.patch, YARN-2179-trunk-v7.patch, 
> YARN-2179-trunk-v8.patch, YARN-2179-trunk-v9.patch
> Implement the initial shared cache manager structure and context. The 
> SCMContext will be used by a number of manager services (i.e. the backing 
> store and the cleaner service). The AppChecker is used to gather the 
> currently running applications on SCM startup (necessary for an scm that is 
> backed by an in-memory store).

This message was sent by Atlassian JIRA

Reply via email to