Chris Trezzo updated YARN-2180:
    Attachment: YARN-2180-trunk-v6.patch

[~kasha] [~vinodkv] [~sjlee0]

Attached is v6. Here are the major changes:
1. Moved in-memory implementation specific logic to check for initial apps from 
the cleaner service to the InMemorySCMStore. Also updated unit tests.
2. Got rid of InMemorySCMStoreConfiguration and added them back to 
YarnConfigruation with an in-memory store prefix.
3. Added configuration around AppChecker implementation in the in-memory store.
4. Changed synchronization of initialApps to use a separate lock object.
5. Annotated classes with private/evolving.
6. Addressed various notes from karthik.

One specific comment:
bq. For resources that are not in the store, isn't the access time trivially 
zero? I am okay with returning -1 for those cases, but will returning zero help 
at call sites?

I am going through and trying to verify if everything would be OK returning an 
access time of 0 instead of -1. If I remember correctly, this covered a case 
around SCM crashing and the Uploader service on the node manager. I will jog my 
memory and come up with a better response. The only place that this method is 
called is in the isResourceEvictable method.

> In-memory backing store for cache manager
> -----------------------------------------
>                 Key: YARN-2180
>                 URL: https://issues.apache.org/jira/browse/YARN-2180
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>         Attachments: YARN-2180-trunk-v1.patch, YARN-2180-trunk-v2.patch, 
> YARN-2180-trunk-v3.patch, YARN-2180-trunk-v4.patch, YARN-2180-trunk-v5.patch, 
> YARN-2180-trunk-v6.patch
> Implement an in-memory backing store for the cache manager.

This message was sent by Atlassian JIRA

Reply via email to