[
https://issues.apache.org/jira/browse/YARN-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154371#comment-14154371
]
Jian He commented on YARN-2609:
-------------------------------
looks good overall, some minor comments:
- we can use the newInstance method
{code}
ReservationSubmissionRequest request =
new ReservationSubmissionRequestPBImpl();
ReservationDefinition rDef = new ReservationDefinitionPBImpl();
ReservationRequests reqs = new ReservationRequestsPBImpl();
{code}
- I found the setter is set{{ReservationResources}}, but the parameter type is
{{ReservationRequest}}, is this inconsistency intentional ?
{code}
public abstract void setReservationResources(
List<ReservationRequest> reservationResources);
{code}
> Example of use for the ReservationSystem
> ----------------------------------------
>
> Key: YARN-2609
> URL: https://issues.apache.org/jira/browse/YARN-2609
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Priority: Minor
> Attachments: YARN-2609.docx, YARN-2609.patch
>
>
> This JIRA provides a simple new example in mapreduce-examples that request a
> reservation and submit a Pi computation in the reservation. This is meant
> just to show how to interact with the reservation system.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
