[ 
https://issues.apache.org/jira/browse/YARN-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154388#comment-14154388
 ] 

Zhijie Shen commented on YARN-2630:
-----------------------------------

Is it correct to only notify NM when keepContainersAcrossApplicationAttempts is 
set? Logically no matter we keep the containers across attempts, we should let 
NM cleanup the cached finished containers, right? It seems that 
pullJustFinishedContainers doesn't need this check.
{code}
    if (!appAttempt.getSubmissionContext()
      .getKeepContainersAcrossApplicationAttempts()) {
      appAttempt.sendFinishedContainersToNM();
    }
{code}

> TestDistributedShell#testDSRestartWithPreviousRunningContainers fails
> ---------------------------------------------------------------------
>
>                 Key: YARN-2630
>                 URL: https://issues.apache.org/jira/browse/YARN-2630
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-2630.1.patch, YARN-2630.2.patch
>
>
> The problem is that after YARN-1372, in work-preserving AM restart, the 
> re-launched AM will also receive previously failed AM container. But 
> DistributedShell logic is not expecting this extra completed container.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to