[
https://issues.apache.org/jira/browse/YARN-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156951#comment-14156951
]
Jian He commented on YARN-2615:
-------------------------------
looks good, only few minor things:
- {{ClientToAMTokenIdentifierForTest}}, the same code overrides from
{{ClientToAMTokenIdentifier}} may be removed ? similarly for
{{RMDelegationTokenIdentifierForTest}}
- this code can be removed.
{code}
byte[] tokenIdentifierContent = token.getIdentifier();
ClientToAMTokenIdentifier tokenIdentifier = new ClientToAMTokenIdentifier();
DataInputBuffer dib = new DataInputBuffer();
dib.reset(tokenIdentifierContent, tokenIdentifierContent.length);
tokenIdentifier.readFields(dib);
{code}
> ClientToAMTokenIdentifier and DelegationTokenIdentifier should allow extended
> fields
> ------------------------------------------------------------------------------------
>
> Key: YARN-2615
> URL: https://issues.apache.org/jira/browse/YARN-2615
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Junping Du
> Priority: Blocker
> Attachments: YARN-2615-v2.patch, YARN-2615.patch
>
>
> As three TokenIdentifiers get updated in YARN-668, ClientToAMTokenIdentifier
> and DelegationTokenIdentifier should also be updated in the same way to allow
> fields get extended in future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
