Tsuyoshi OZAWA commented on YARN-1879:

Thanks for your comment, Karthik. Almost done to address your comments.

Are there cases when we don't want RetryCache enabled? IMO, we should always 
use the RetryCache (no harm). If we decide on having a config, the default 
should be true.

Basically, we can enable RetryCache without harm and implemented it. One 
concern is tests - on my local, lots tests fail because of following reason:

org.apache.hadoop.metrics2.MetricsException: Metrics source 
RetryCache.AppMasterServiceRetryCache already exists!

I'll try to fix them in next patch by adding 
{{DefaultMetricsSystem.setMiniClusterMode(true);}} to the tests.

> Mark Idempotent/AtMostOnce annotations to ApplicationMasterProtocol
> -------------------------------------------------------------------
>                 Key: YARN-1879
>                 URL: https://issues.apache.org/jira/browse/YARN-1879
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Jian He
>            Assignee: Tsuyoshi OZAWA
>            Priority: Critical
>         Attachments: YARN-1879.1.patch, YARN-1879.1.patch, 
> YARN-1879.11.patch, YARN-1879.12.patch, YARN-1879.13.patch, 
> YARN-1879.14.patch, YARN-1879.15.patch, YARN-1879.16.patch, 
> YARN-1879.17.patch, YARN-1879.18.patch, YARN-1879.2-wip.patch, 
> YARN-1879.2.patch, YARN-1879.3.patch, YARN-1879.4.patch, YARN-1879.5.patch, 
> YARN-1879.6.patch, YARN-1879.7.patch, YARN-1879.8.patch, YARN-1879.9.patch

This message was sent by Atlassian JIRA

Reply via email to