[ 
https://issues.apache.org/jira/browse/YARN-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161127#comment-14161127
 ] 

Jason Lowe commented on YARN-2377:
----------------------------------

Thanks for the patch, Gera.  I think the toString should be on 
SerializedException rather than SerializedExceptionPBImpl, since there's 
nothing implementation-specific about the way it tries to convert to a string 
-- it always goes through the interfaces to get the necessary things.  If a 
specific implementation really needs a different toString method then they can 
always override.

Nit: sringify should be stringify.  Also curious why it isn't static or 
otherwise assumes e == this and not take the additional parameter, since we can 
delegate to cause.stringify when processing the cause portion of the traceback.

> Localization exception stack traces are not passed as diagnostic info
> ---------------------------------------------------------------------
>
>                 Key: YARN-2377
>                 URL: https://issues.apache.org/jira/browse/YARN-2377
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.4.0
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: YARN-2377.v01.patch
>
>
> In the Localizer log one can only see this kind of message
> {code}
> 14/07/31 10:29:00 INFO localizer.ResourceLocalizationService: DEBUG: FAILED { 
> hdfs://ha-nn-uri-0:8020/tmp/hadoop-yarn/staging/gshegalov/.staging/job_1406825443306_0004/job.jar,
>  1406827248944, PATTERN, (?:classes/|lib/).* }, java.net.UnknownHos 
> tException: ha-nn-uri-0
> {code}
> And then only {{ java.net.UnknownHostException: ha-nn-uri-0}} message is 
> propagated as diagnostics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to