Jian He commented on YARN-2588:

Rohith, thanks for the patch, I have a couple of comments:
- the stopActiveServices() call maybe not necessary ? as the AbstractService 
class internally should call stop if any exception occurs.
        } catch (Exception e) {
- maybe we can invoke following right before each time start the active 
- fix following code comment 
// @Test(timeout = 30000)

> Standby RM does not transitionToActive if previous transitionToActive is 
> failed with ZK exception.
> --------------------------------------------------------------------------------------------------
>                 Key: YARN-2588
>                 URL: https://issues.apache.org/jira/browse/YARN-2588
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0, 2.6.0, 2.5.1
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: YARN-2588.patch
> Consider scenario where, StandBy RM is failed to transition to Active because 
> of ZK exception(connectionLoss or SessionExpired). Then any further 
> transition to Active for same RM does not move RM to Active state.

This message was sent by Atlassian JIRA

Reply via email to