zhihai xu commented on YARN-2682:

I attached a new patch YARN-2682.001.patch to call getWorkingDir  instead of 
getFirstApplicationDir in WSCE and remove getFirstApplicationDir function in 
DCE. This patch doesn't need unit test because the unit test for getWorkingDir 
is already done in TestDefaultContainerExecutor.

> WindowsSecureContainerExecutor should not depend on 
> DefaultContainerExecutor#getFirstApplicationDir. 
> -----------------------------------------------------------------------------------------------------
>                 Key: YARN-2682
>                 URL: https://issues.apache.org/jira/browse/YARN-2682
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.5.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-2682.000.patch, YARN-2682.001.patch
> DefaultContainerExecutor won't use getFirstApplicationDir any more. But we 
> can't delete getFirstApplicationDir in DefaultContainerExecutor because 
> WindowsSecureContainerExecutor uses it.
> We should move getFirstApplicationDir function from DefaultContainerExecutor 
> to WindowsSecureContainerExecutor.

This message was sent by Atlassian JIRA

Reply via email to