[ 
https://issues.apache.org/jira/browse/YARN-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172497#comment-14172497
 ] 

Wangda Tan commented on YARN-2314:
----------------------------------

[~jlowe],
Thanks for updating the patch, generally it looks very good to me. A minor 
suggestion is, I'd suggest to change yarn.client.max-nodemanagers-proxies to 
yarn.client.max-cached-nodemanagers-proxies. Because when the user set the 
MAX_NM_PROXIES to 0, he/she can still connect to more than 0 NMs, even if the 
java docs is very clear, but the name is still a little confusing.

Wangda

> ContainerManagementProtocolProxy can create thousands of threads for a large 
> cluster
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-2314
>                 URL: https://issues.apache.org/jira/browse/YARN-2314
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.1.0-beta
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>            Priority: Critical
>         Attachments: YARN-2314.patch, disable-cm-proxy-cache.patch, 
> nmproxycachefix.prototype.patch
>
>
> ContainerManagementProtocolProxy has a cache of NM proxies, and the size of 
> this cache is configurable.  However the cache can grow far beyond the 
> configured size when running on a large cluster and blow AM address/container 
> limits.  More details in the first comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to