Vinod Kumar Vavilapalli commented on YARN-2505:

bq. /nodes/<nodeId>/node-labels seems like an over-use of node before labels 
because the prefixes in the REST url kind of seem deterministic of the context. 
should we replace that with just "labels" instead?

bq. same for /cluster-node-labels, what do you think about /cluster/labels?
+1, I like this much better, but /cluster/node-labels instead.

bq. do we foresee a usecase where labels could be provided on 
resources/entities other than nodes? for example applications?
Yeah, we already have known priorities/priority labels being proposed at 
YARN-1963, so I made sure we explicitly say node-labels everywhere to avoid 

bq. if the intention is to highlight that these labels are only for nodes, do 
you think passing a parameter "type=node" and likewise would make more sense? 
this of course would be useful only when the above question holds true.
We will then have to invent a label-type, seems like an over-kill to me.

> Support get/add/remove/change labels in RM REST API
> ---------------------------------------------------
>                 Key: YARN-2505
>                 URL: https://issues.apache.org/jira/browse/YARN-2505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Craig Welch
>         Attachments: YARN-2505.1.patch, YARN-2505.patch

This message was sent by Atlassian JIRA

Reply via email to