Wangda Tan commented on YARN-2504:

bq. Let's update the APIs to be named inline with the last patch at YARN-2544 - 
addToClusterNodeLabels etc.
bq. Similarly the CLI options
bq. We had dropped the clear-labels option?

bq. getNodeToLabels() doesn't need to be in the admin-protocol or the admin-CLI
bq. Similarly getLabels()
Offline chat with Vinod, we can address that in a separated patch

bq. Change the usage strings of the CLIs to instead say "Comma separated list 
of node-labels"

bq. Not sure why we need doNotRetry here. The ClientRMProxy is the right layer 
to do this.
bq. On a related note, we shouldn't do this "try RM, fall back to local-store". 
We need to have modes in RMAdminCLI which can be used to run the 
Added an option "directlyAccessNodeLabelStore" to let admin explicitly specify 
if it need access local-store directly or RM.

I'm not sure what you meant, did you mean we need move the security 
verification code to RMNodeLabelsManager?


> Support get/add/remove/change labels in RM admin CLI 
> -----------------------------------------------------
>                 Key: YARN-2504
>                 URL: https://issues.apache.org/jira/browse/YARN-2504
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2504-20141015-1.patch, YARN-2504.patch

This message was sent by Atlassian JIRA

Reply via email to