Wangda Tan commented on YARN-2723:

[~Naganarasimha], is there any updates on this patch? It should be a one line 
fix with a new test, if you didn't start on it, I can take it over.

> rmadmin -replaceLabelsOnNode does not correctly parse port
> ----------------------------------------------------------
>                 Key: YARN-2723
>                 URL: https://issues.apache.org/jira/browse/YARN-2723
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Phil D'Amore
>            Assignee: Naganarasimha G R
> There is an off-by-one issue in RMAdminCLI.java (line 457):
> port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")));
> should probably be:
> port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")+1));
> Currently attempting to add a label to a node with a port specified looks 
> like this:
> [yarn@ip-10-0-0-66 ~]$ yarn rmadmin -replaceLabelsOnNode 
> node.example.com:45454,test-label
> replaceLabelsOnNode: For input string: ":45454"
> Usage: yarn rmadmin [-replaceLabelsOnNode [node1:port,label1,label2 
> node2:port,label1,label2]]
> It appears to be trying to parse the ':' as part of the integer because the 
> substring index is off.

This message was sent by Atlassian JIRA

Reply via email to