[ 
https://issues.apache.org/jira/browse/YARN-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181050#comment-14181050
 ] 

Hadoop QA commented on YARN-2723:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12676529/yarn-2723.20141023.2.patch
  against trunk revision d71d40a.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:

                  
org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5513//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5513//console

This message is automatically generated.

> rmadmin -replaceLabelsOnNode does not correctly parse port
> ----------------------------------------------------------
>
>                 Key: YARN-2723
>                 URL: https://issues.apache.org/jira/browse/YARN-2723
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Phil D'Amore
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2723.20141023.1.patch, yarn-2723.20141023.2.patch
>
>
> There is an off-by-one issue in RMAdminCLI.java (line 457):
> port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")));
> should probably be:
> port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")+1));
> Currently attempting to add a label to a node with a port specified looks 
> like this:
> [yarn@ip-10-0-0-66 ~]$ yarn rmadmin -replaceLabelsOnNode 
> node.example.com:45454,test-label
> replaceLabelsOnNode: For input string: ":45454"
> Usage: yarn rmadmin [-replaceLabelsOnNode [node1:port,label1,label2 
> node2:port,label1,label2]]
> It appears to be trying to parse the ':' as part of the integer because the 
> substring index is off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to