[ 
https://issues.apache.org/jira/browse/YARN-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182018#comment-14182018
 ] 

Hadoop QA commented on YARN-2726:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12676662/YARN-2726-20141023-1.patch
  against trunk revision d71d40a.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The following test timeouts occurred in 
hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.fs.permission.TestStickyBitTTests
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrationTeTests
org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgTestsTests
org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolTestsTests
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporTestsTests
org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCaTestTests
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRTestsTests
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeMaTests
org.apache.hadoop.hdfs.TestEncryptionZonesWiTests
org.apache.hadoop.hdfs.TestDFSClientRetrTestTests
org.apache.hadoop.hdfs.TestFileCreaTestsTests
org.apache.hadoop.hdfs.TestDatanodeTests
org.apache.hadoop.hdfs.TestLeaseReTests
org.apache.hadoop.hdfs.TestDatanodeBlockScTests
org.apache.hadoop.hdfs.qjournal.client.TestQJMWithTests
org.apache.hadoop.hdfs.TestGetTests
org.apache.hadoop.tracing.TestTraceAdmin

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5519//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5519//console

This message is automatically generated.

> CapacityScheduler should explicitly log when an accessible label has no 
> capacity
> --------------------------------------------------------------------------------
>
>                 Key: YARN-2726
>                 URL: https://issues.apache.org/jira/browse/YARN-2726
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Phil D'Amore
>            Assignee: Wangda Tan
>            Priority: Minor
>         Attachments: YARN-2726-20141023-1.patch
>
>
> Given:
> - Node label defined: test-label
> - Two queues defined: a, b
> - label accessibility and and capacity defined as follows (properties 
> abbreviated for readability):
> root.a.accessible-node-labels = test-label
> root.a.accessible-node-labels.test-label.capacity = 100
> If you restart the RM or do a 'rmadmin -refreshQueues' you will get a stack 
> trace with the following error buried within:
> "Illegal capacity of -1.0 for label=test-label in queue=root.b"
> This of course occurs because test-label is accessible to b due to 
> inheritance from the root, and -1 is the UNDEFINED value.  To my mind this 
> might not be obvious to the admin, and the error message which results does 
> not help guide someone to the source of the issue.
> I propose that this situation be updated so that when the capacity on an 
> accessible label is undefined, it is explicitly called out instead of falling 
> through to the illegal capacity check.  Something like:
> {code}
> if (capacity == UNDEFINED) {
>     throw new IllegalArgumentException("Configuration issue: " + " label=" + 
> label + " is accessible from queue=" + queue + " but has no capacity set.");
> }
> {code}
> I'll leave it to better judgement than mine as to whether I'm throwing the 
> appropriate exception there.  I think this check should be added to both 
> getNodeLabelCapacities and getMaximumNodeLabelCapacities in 
> CapacitySchedulerConfiguration.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to