[jira] [Commented] (YARN-2712) Adding tests about FSQueue and headroom of FairScheduler to TestWorkPreservingRMRestart

[Anubhav Dhoot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183598#comment-14183598
 ] 

Anubhav Dhoot commented on YARN-2712:
-------------------------------------

Minor comments below. LGTM otherwise

These lines can be removed as rm start should take care of it
    {noformat}
    FairScheduler scheduler = (FairScheduler) rm.getResourceScheduler();
    scheduler.init(conf);
    scheduler.start();
    scheduler.reinitialize(conf, rm.getRMContext());
{noformat}

Is this relevant to the test case ?
{noformat}
    if (schedulerClass.equals(FairScheduler.class)) {
      Assert.assertEquals(
          Resource.newInstance(8192, 8),
          ((FairScheduler)rm1.getResourceScheduler())
              .getQueueManager().getRootQueue().getFairShare());
{noformat}


> Adding tests about FSQueue and headroom of FairScheduler to 
> TestWorkPreservingRMRestart
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-2712
>                 URL: https://issues.apache.org/jira/browse/YARN-2712
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2712.1.patch
>
>
> TestWorkPreservingRMRestart#testSchedulerRecovery doesn't have test cases 
> about FairScheduler partially. We should support them.
> {code}
>    // Until YARN-1959 is resolved
>    if (scheduler.getClass() != FairScheduler.class) {
>      assertEquals(availableResources, schedulerAttempt.getHeadroom());
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)